-
Notifications
You must be signed in to change notification settings - Fork 42
Update to ACK runtime v0.56.0, code-generator v0.56.0
#199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| jobs: | ||
| call-hydrate-go-proxy: | ||
| uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 12 days ago
To fix this problem, add an explicit permissions section to the workflow. This can be done at the root of the workflow file (which applies to all jobs unless overridden), or at the job level for the specific job. Placing it at the root is the best approach, ensuring no job can inadvertently escalate permissions unless intentionally specified. For most workflows, especially those that just call other workflows or perform read-only actions, the recommended minimum is contents: read. If the workflow requires write permissions for particular resources (e.g., for updating pull requests or issues), these should be added specifically. Here, as a minimal and safe starting point, add at the root:
permissions:
contents: readThis should be inserted after the name (line 1), before the on: trigger, so that it clearly applies to all jobs.
-
Copy modified lines R2-R3
| @@ -1,4 +1,6 @@ | ||
| name: Hydrate Go Proxy | ||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| push: |
|
/lgtm |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, ack-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ack-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Update to ACK runtime
v0.56.0, code-generatorv0.56.0v0.56.0release notesv0.56.0release notesNOTE:
This PR increments the release version of service controller from
v1.2.4tov1.3.0Once this PR is merged, release
v1.3.0will be automatically created forelasticache-controllerPlease close this PR, if you do not want the new patch release for
elasticache-controllerstdout for
make build-controller:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.