Skip to content

Conversation

@ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Nov 29, 2025

Update to ACK runtime v0.56.0, code-generator v0.56.0



NOTE:
This PR increments the release version of service controller from v1.2.4 to v1.3.0

Once this PR is merged, release v1.3.0 will be automatically created for elasticache-controller

Please close this PR, if you do not want the new patch release for elasticache-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building elasticache-controller ====
Copying common custom resource definitions into elasticache
Building Kubernetes API objects for elasticache
Generating deepcopy code for elasticache
Generating custom resource definitions for elasticache
Building service controller for elasticache
Running GO mod tidy
Generating RBAC manifests for elasticache
Running gofmt against generated code for elasticache
Updating additional GitHub repository maintenance files
==== building elasticache-controller release artifacts ====
Building release artifacts for elasticache-v1.3.0
Generating common custom resource definitions
Generating custom resource definitions for elasticache
Generating RBAC manifests for elasticache

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label Nov 29, 2025
@ack-prow ack-prow bot requested review from a-hilaly and knottnt November 29, 2025 02:59

jobs:
call-hydrate-go-proxy:
uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 12 days ago

To fix this problem, add an explicit permissions section to the workflow. This can be done at the root of the workflow file (which applies to all jobs unless overridden), or at the job level for the specific job. Placing it at the root is the best approach, ensuring no job can inadvertently escalate permissions unless intentionally specified. For most workflows, especially those that just call other workflows or perform read-only actions, the recommended minimum is contents: read. If the workflow requires write permissions for particular resources (e.g., for updating pull requests or issues), these should be added specifically. Here, as a minimal and safe starting point, add at the root:

permissions:
  contents: read

This should be inserted after the name (line 1), before the on: trigger, so that it clearly applies to all jobs.

Suggested changeset 1
.github/workflows/postsubmit.yaml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/postsubmit.yaml b/.github/workflows/postsubmit.yaml
--- a/.github/workflows/postsubmit.yaml
+++ b/.github/workflows/postsubmit.yaml
@@ -1,4 +1,6 @@
 name: Hydrate Go Proxy
+permissions:
+  contents: read
 
 on:
   push:
EOF
@@ -1,4 +1,6 @@
name: Hydrate Go Proxy
permissions:
contents: read

on:
push:
Copilot is powered by AI and may make mistakes. Always verify output.
@a-hilaly
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2025
@a-hilaly
Copy link
Member

/retest

@ack-prow
Copy link

ack-prow bot commented Nov 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Nov 29, 2025
@ack-prow
Copy link

ack-prow bot commented Nov 29, 2025

@ack-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
elasticache-verify-code-gen 3786baf link false /test elasticache-verify-code-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ack-prow ack-prow bot merged commit 0b34b8e into main Nov 29, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged. prow/auto-gen PRs related to prow auto generation automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants