feat: Add support for Job resource
#4
Conversation
|
/retest |
michaelhtm
force-pushed
the
feat/jobsupport
branch
from
f4265c2 to
e39761c
Compare
rushmash91
left a comment
rushmash91
left a comment
There was a problem hiding this comment.
thanks @michaelhtm ! left a few comments..
|
/hold |
ack-prow
bot
added
the
do-not-merge/hold
michaelhtm
force-pushed
the
feat/jobsupport
branch
5 times, most recently
from
27d5f36 to
8f467d1
Compare
rushmash91
left a comment
rushmash91
left a comment
There was a problem hiding this comment.
thank @michaelhtm! left a few comments..
michaelhtm
force-pushed
the
feat/jobsupport
branch
4 times, most recently
from
5d64568 to
4793bc5
Compare
There was a problem hiding this comment.
easily one of the largest generated sdk.go files in ACK :)
|
/unhold |
ack-prow
bot
removed
the
do-not-merge/hold
michaelhtm
force-pushed
the
feat/jobsupport
branch
from
1169b73 to
aa1d312
Compare
michaelhtm
force-pushed
the
feat/jobsupport
branch
from
aa1d312 to
2d6129b
Compare
|
@michaelhtm: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| } | ||
| {{- end }} | ||
| {{- end }} | ||
|
|
There was a problem hiding this comment.
why is this required? Can we have a comment block here to explain since this isnt a common pattern ..
There was a problem hiding this comment.
it's just template syntax..the first end ends the range, and the second one ends the if
https://github.com/aws-controllers-k8s/glue-controller/pull/4/files#diff-41d0971317684f08f13145085baa675ea142d8cf3554f47f969c9db560ba5153R6-R7
The same pattern can be seen here: https://github.com/aws-controllers-k8s/acm-controller/blob/main/templates/hooks/certificate/sdk_file_end.go.tpl#L40
| api_version: v1alpha1 | ||
| aws_sdk_go_version: v1.55.5 | ||
| aws_sdk_go_version: v1.32.6 | ||
| generator_config_info: |
There was a problem hiding this comment.
is the SDK version change internded?
There was a problem hiding this comment.
yes, the first one was the GoV1 sdk
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Issue #2146
Description of changes:
Add Support for Job resource
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.