-
Notifications
You must be signed in to change notification settings - Fork 13
Update to ACK runtime v0.56.0, code-generator v0.56.0
#87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| jobs: | ||
| call-hydrate-go-proxy: | ||
| uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 5 days ago
To fix this problem, add a permissions block at the workflow root level (before the jobs: key) in .github/workflows/postsubmit.yaml. If you do not know the precise permissions required by the called workflow (aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml), start with a secure default of contents: read (which is the least privilege required for most workflows), and adapt as needed when requirements become clearer. This approach ensures that inherited permissions do not unintentionally allow write access to all repository resources. Insert these lines after the workflow name: and before the on: section (to match common workflow syntax).
-
Copy modified lines R3-R5
| @@ -1,5 +1,8 @@ | ||
| name: Hydrate Go Proxy | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| push: | ||
| branches: |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, ack-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ack-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test kafka-kind-e2e |
Update to ACK runtime
v0.56.0, code-generatorv0.56.0v0.56.0release notesv0.56.0release notesNOTE:
This PR increments the release version of service controller from
v1.2.2tov1.3.0Once this PR is merged, release
v1.3.0will be automatically created forkafka-controllerPlease close this PR, if you do not want the new patch release for
kafka-controllerstdout for
make build-controller:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.