fix: address lambda E2E test flaky timeout failures#213
Merged
ack-prow[bot] merged 1 commit intoaws-controllers-k8s:mainfrom Apr 9, 2026
Merged
fix: address lambda E2E test flaky timeout failures#213ack-prow[bot] merged 1 commit intoaws-controllers-k8s:mainfrom
ack-prow[bot] merged 1 commit intoaws-controllers-k8s:mainfrom
Conversation
4523795 to
cf01c04
Compare
Contributor
Author
|
/retest |
32abec9 to
7beac7c
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelhtm, sapphirew The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Under 33-way pytest-xdist parallel runs, controller reconciliation and resource deletion can exceed the acktest default timeouts (30s and 5s), causing non-deterministic test failures. Increase timeouts at call sites in all 7 lambda E2E test files without modifying acktest library defaults:
Increase
wait_resource_consumed_by_controllertimeout at call sites: Change all calls fromk8s.wait_resource_consumed_by_controller(ref)(using defaults: 3 periods × 10s = 30s) tok8s.wait_resource_consumed_by_controller(ref, wait_periods=10, period_length=10)(10 periods × 10s = 100s). This provides ~3× headroom over the current 30s default for parallel execution.Increase
delete_custom_resourcetimeout at call sites: Change all calls fromk8s.delete_custom_resource(ref)(using defaults: 1 period × 5s = 5s) tok8s.delete_custom_resource(ref, wait_periods=3, period_length=10)(3 periods × 10s = 30s). This provides 6× headroom over the current 5s default.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.