Skip to content

Conversation

@ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Nov 29, 2025

Update to ACK runtime v0.56.0, code-generator v0.56.0



NOTE:
This PR increments the release version of service controller from v1.1.2 to v1.2.0

Once this PR is merged, release v1.2.0 will be automatically created for memorydb-controller

Please close this PR, if you do not want the new patch release for memorydb-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building memorydb-controller ====
Copying common custom resource definitions into memorydb
Building Kubernetes API objects for memorydb
Generating deepcopy code for memorydb
Generating custom resource definitions for memorydb
Building service controller for memorydb
Running GO mod tidy
Generating RBAC manifests for memorydb
Running gofmt against generated code for memorydb
Updating additional GitHub repository maintenance files
==== building memorydb-controller release artifacts ====
Building release artifacts for memorydb-v1.2.0
Generating common custom resource definitions
Generating custom resource definitions for memorydb
Generating RBAC manifests for memorydb

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label Nov 29, 2025
@ack-prow ack-prow bot requested review from knottnt and rushmash91 November 29, 2025 03:02

jobs:
call-hydrate-go-proxy:
uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 5 days ago

To fix the issue, we should add an explicit permissions block to the workflow to control the permissions of GITHUB_TOKEN. Since this workflow calls a reusable workflow, unless any steps require writing repository contents or pull requests, the safest minimal block is to set contents: read. This can be set at the workflow root so it applies to all jobs, following the standard recommended layout. This change only needs to be made in the .github/workflows/postsubmit.yaml file, added after the name declaration (line 1) and before the on: key (line 3).

Suggested changeset 1
.github/workflows/postsubmit.yaml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/postsubmit.yaml b/.github/workflows/postsubmit.yaml
--- a/.github/workflows/postsubmit.yaml
+++ b/.github/workflows/postsubmit.yaml
@@ -1,4 +1,6 @@
 name: Hydrate Go Proxy
+permissions:
+  contents: read
 
 on:
   push:
EOF
@@ -1,4 +1,6 @@
name: Hydrate Go Proxy
permissions:
contents: read

on:
push:
Copilot is powered by AI and may make mistakes. Always verify output.
@ack-prow
Copy link

ack-prow bot commented Nov 29, 2025

@ack-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
memorydb-verify-code-gen f61be56 link false /test memorydb-verify-code-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added lgtm Indicates that a PR is ready to be merged. approved labels Nov 29, 2025
@a-hilaly
Copy link
Member

/lgtm

@ack-prow
Copy link

ack-prow bot commented Nov 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 23f1f51 into main Nov 29, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged. prow/auto-gen PRs related to prow auto generation automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants