Skip to content

Conversation

@ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Nov 29, 2025

Update to ACK runtime v0.56.0, code-generator v0.56.0



NOTE:
This PR increments the release version of service controller from v1.1.3 to v1.2.0

Once this PR is merged, release v1.2.0 will be automatically created for pipes-controller

Please close this PR, if you do not want the new patch release for pipes-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building pipes-controller ====
Copying common custom resource definitions into pipes
Building Kubernetes API objects for pipes
Generating deepcopy code for pipes
Generating custom resource definitions for pipes
Building service controller for pipes
Running GO mod tidy
Generating RBAC manifests for pipes
Running gofmt against generated code for pipes
Updating additional GitHub repository maintenance files
==== building pipes-controller release artifacts ====
Building release artifacts for pipes-v1.2.0
Generating common custom resource definitions
Generating custom resource definitions for pipes
Generating RBAC manifests for pipes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label Nov 29, 2025
@ack-prow ack-prow bot requested review from knottnt and michaelhtm November 29, 2025 03:31

jobs:
call-hydrate-go-proxy:
uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 1 day ago

To fix this issue, you need to add a permissions block that specifies the minimal required permissions at the root of the workflow (.github/workflows/postsubmit.yaml). The block should either restrict to read-only access (if that suffices) or specify more granular permissions as required by the workflow's jobs. As we do not have specific information on the permissions required by reusable-postsubmit.yaml, the safest minimal default is contents: read, which only allows read access to repository contents. The permissions block should be inserted after the name: or before/after on: at the workflow root (line 2 or 3).

Suggested changeset 1
.github/workflows/postsubmit.yaml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/postsubmit.yaml b/.github/workflows/postsubmit.yaml
--- a/.github/workflows/postsubmit.yaml
+++ b/.github/workflows/postsubmit.yaml
@@ -1,4 +1,6 @@
 name: Hydrate Go Proxy
+permissions:
+  contents: read
 
 on:
   push:
EOF
@@ -1,4 +1,6 @@
name: Hydrate Go Proxy
permissions:
contents: read

on:
push:
Copilot is powered by AI and may make mistakes. Always verify output.
@a-hilaly
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2025
@ack-prow
Copy link

ack-prow bot commented Nov 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Nov 29, 2025
@ack-prow ack-prow bot merged commit c74aeb5 into main Nov 29, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged. prow/auto-gen PRs related to prow auto generation automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants