Skip to content

Conversation

@knottnt
Copy link
Contributor

@knottnt knottnt commented May 5, 2025

Issue #, if available: 2221

Description of changes:

  • Update HTTP regex to only match if not followed by an "S" and additional capital letter and Http to only match if not followed by "s".
  • Add additional test cases for common HTTP related field names.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

knottnt added 3 commits May 5, 2025 10:08
Add test cases for HTTP and HTTPS fields.
Reduce scope of HTTP regex to only match with HTTP if not followed by an 'S' and another capital letter and Http if not followed be can 's'.
Add additional test case for Http vs Https
@ack-prow ack-prow bot requested review from a-hilaly and jaypipes May 5, 2025 17:18
@ack-prow
Copy link

ack-prow bot commented May 5, 2025

@knottnt: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution 2f89dc3 link false /test verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! :)

@ack-prow
Copy link

ack-prow bot commented May 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaypipes, knottnt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label May 5, 2025
@knottnt knottnt merged commit b250a88 into aws-controllers-k8s:main May 5, 2025
1 of 3 checks passed
@knottnt knottnt deleted the fix-reduce-http-regex-matches branch May 5, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants