-
Notifications
You must be signed in to change notification settings - Fork 60
Update to ACK runtime v0.56.0, code-generator v0.56.0
#253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| jobs: | ||
| call-hydrate-go-proxy: | ||
| uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 4 days ago
To fix the issue, we should add a permissions: block specifying the minimal required privileges for the workflow. The best way is to add a permissions: block at the top (workflow root level), but placing it at the job level is also valid. Since the YAML shown does not indicate any specific permissions are needed for this job (and since it just delegates to a reusable workflow), start with permissions: {} to grant no permissions at all. If it is later found that read access is required (e.g., by the reusable workflow), use permissions: contents: read.
We'll add the permissions: block at the root level in .github/workflows/postsubmit.yaml, between the name: section and the on: section, matching the standard layout. No additional imports or configuration is needed—just the addition of the following lines:
permissions: {}-
Copy modified line R2
| @@ -1,4 +1,5 @@ | ||
| name: Hydrate Go Proxy | ||
| permissions: {} | ||
|
|
||
| on: | ||
| push: |
|
@ack-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, ack-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update to ACK runtime
v0.56.0, code-generatorv0.56.0v0.56.0release notesv0.56.0release notesNOTE:
This PR increments the release version of service controller from
v1.6.3tov1.7.0Once this PR is merged, release
v1.7.0will be automatically created forrds-controllerPlease close this PR, if you do not want the new patch release for
rds-controllerstdout for
make build-controller:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.