Skip to content

Conversation

@ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Nov 29, 2025

Update to ACK runtime v0.56.0, code-generator v0.56.0



NOTE:
This PR increments the release version of service controller from v1.6.3 to v1.7.0

Once this PR is merged, release v1.7.0 will be automatically created for rds-controller

Please close this PR, if you do not want the new patch release for rds-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building rds-controller ====
Copying common custom resource definitions into rds
Building Kubernetes API objects for rds
Generating deepcopy code for rds
Generating custom resource definitions for rds
Building service controller for rds
Running GO mod tidy
Generating RBAC manifests for rds
Running gofmt against generated code for rds
Updating additional GitHub repository maintenance files
==== building rds-controller release artifacts ====
Building release artifacts for rds-v1.7.0
Generating common custom resource definitions
Generating custom resource definitions for rds
Generating RBAC manifests for rds

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label Nov 29, 2025
@ack-prow ack-prow bot requested review from knottnt and michaelhtm November 29, 2025 03:45

jobs:
call-hydrate-go-proxy:
uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 4 days ago

To fix the issue, we should add a permissions: block specifying the minimal required privileges for the workflow. The best way is to add a permissions: block at the top (workflow root level), but placing it at the job level is also valid. Since the YAML shown does not indicate any specific permissions are needed for this job (and since it just delegates to a reusable workflow), start with permissions: {} to grant no permissions at all. If it is later found that read access is required (e.g., by the reusable workflow), use permissions: contents: read.

We'll add the permissions: block at the root level in .github/workflows/postsubmit.yaml, between the name: section and the on: section, matching the standard layout. No additional imports or configuration is needed—just the addition of the following lines:

permissions: {}

Suggested changeset 1
.github/workflows/postsubmit.yaml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/postsubmit.yaml b/.github/workflows/postsubmit.yaml
--- a/.github/workflows/postsubmit.yaml
+++ b/.github/workflows/postsubmit.yaml
@@ -1,4 +1,5 @@
 name: Hydrate Go Proxy
+permissions: {}
 
 on:
   push:
EOF
@@ -1,4 +1,5 @@
name: Hydrate Go Proxy
permissions: {}

on:
push:
Copilot is powered by AI and may make mistakes. Always verify output.
@ack-prow
Copy link

ack-prow bot commented Nov 29, 2025

@ack-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
rds-verify-code-gen 80ecd43 link false /test rds-verify-code-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@a-hilaly
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2025
@ack-prow
Copy link

ack-prow bot commented Nov 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Nov 29, 2025
@ack-prow ack-prow bot merged commit d9fef91 into main Nov 29, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged. prow/auto-gen PRs related to prow auto generation automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants