Skip to content

fix: force disable CARM when only one namespace is watched #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 18, 2025
Merged

fix: force disable CARM when only one namespace is watched #201

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3ca0c51
fix: force disable CARM when only one namespace is watched
vjdandu Sep 18, 2025
0fd4ad1
clean up conditionals
vjdandu Sep 18, 2025
04f0e64
fix if else logic
vjdandu Sep 18, 2025
c0ee4b5
remove extra line
vjdandu Sep 18, 2025
758af73
fix formatting
vjdandu Sep 18, 2025
23cf3f5
revert to previous formatting
vjdandu Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions pkg/runtime/service_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,20 +221,25 @@ func (c *serviceController) BindControllerManager(mgr ctrlrt.Manager, cfg ackcfg
cfg.FeatureGates,
)
// The caches are only used for cross account resource management. We
// want to run them only when --enable-carm is set to true.
// want to run them only when --enable-carm is set to true and
// --watch-namespace is set to zero or more than one namespaces.
if cfg.EnableCARM {
clusterConfig := mgr.GetConfig()
clientSet, err := kubernetes.NewForConfig(clusterConfig)
if err != nil {
return err
if len(namespaces) == 1 {
c.log.V(0).Info("--enable-carm is set to true but --watch-namespace is set to a single namespace. CARM will not be enabled.")
} else {
clusterConfig := mgr.GetConfig()
clientSet, err := kubernetes.NewForConfig(clusterConfig)
if err != nil {
return err
}
// Run the caches. This will not block as the caches are run in
// separate goroutines.
cache.Run(clientSet)
// Wait for the caches to sync
ctx := context.TODO()
synced := cache.WaitForCachesToSync(ctx)
c.log.Info("Waited for the caches to sync", "synced", synced)
}
// Run the caches. This will not block as the caches are run in
// separate goroutines.
cache.Run(clientSet)
// Wait for the caches to sync
ctx := context.TODO()
synced := cache.WaitForCachesToSync(ctx)
c.log.Info("Waited for the caches to sync", "synced", synced)
}

if cfg.EnableAdoptedResourceReconciler {
Expand Down