fix for #866 - nil Interface check during delete #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumargauravsharma
requested review from
a-hilaly
and removed request for
a-hilaly
vijtrip2
reviewed
Jul 14, 2021
pkg/runtime/reconciler.go
Outdated
| latest, err := rm.Delete(ctx, observed) | ||
| rlog.Exit("rm.Delete", err) | ||
| if latest != nil { | ||
| if latest != nil && !reflect.ValueOf(latest).IsNil() { |
There was a problem hiding this comment.
I would recommend reusing this IsNil() method.
https://github.com/aws-controllers-k8s/runtime/blob/main/pkg/compare/nil.go#L35
There was a problem hiding this comment.
Thanks @vijtrip2
I have updated it to use IsNotNil() from: https://github.com/aws-controllers-k8s/runtime/blob/main/pkg/compare/nil.go#L47
kumargauravsharma
force-pushed
the
delete-progress
branch
from
b3d97b0 to
05fcc4a
Compare
vijtrip2
approved these changes
Jul 15, 2021
a-hilaly
approved these changes
Jul 15, 2021
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, kumargauravsharma, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
aws-controllers-k8s/community#866
Fix:
nilInterface check during deleteBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.