Skip to content

Conversation

@RedbackThomson
Copy link
Contributor

Some status fields were not being set properly during the first reconciliation loop, as part of the Create flow. This loop called the Create* operation, and set any status fields that are returned as part of the output shape, and then returned successfully (without re-queuing). Previously, the reconciler would loop again to describe and set the other status fields, however we now filter out any events that do not change the resource generation.

This fix will call ReadOne to describe the newly created resource and set the status fields based on that response, directly after calling Create*. This ensures all fields are set before completing the first reconciliation loop.

@ack-bot ack-bot requested review from a-hilaly and vijtrip2 August 9, 2021 19:15
@RedbackThomson
Copy link
Contributor Author

Tested with @a-hilaly for DynamoDB. We see an initial reconciliation loop that sets the status as "Creating" before it requeues (based on hook logic) to eventually set it to status "Active".

@RedbackThomson
Copy link
Contributor Author

Tested with @ryansteakley that the SageMaker ModelPackageGroup has returned to normal, as well. He only sees a single reconciliation loop, and all status fields are filled.

@RedbackThomson
Copy link
Contributor Author

I have updated the PR so that we call resource.SetStatus so that we only update the status fields returned from the ReadOne. Spec fields returned from ReadOne should be handled by the late initializer logic, and will be introduced separately.

@jaypipes
Copy link
Collaborator

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Aug 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, jaypipes, RedbackThomson, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [A-Hilaly,RedbackThomson,jaypipes,vijtrip2]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 9a99433 into aws-controllers-k8s:main Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants