Skip to content

Call ReadOne as part of createResource #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2021
Merged

Call ReadOne as part of createResource #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22a51cc
Call ReadOne as part of createResource
Aug 9, 2021
dd0fa62
Add SetStatus to Resource
Aug 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pkg/runtime/reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,17 @@ func (r *resourceReconciler) createResource(
if err != nil {
return latest, err
}

rlog.Enter("rm.ReadOne")
observed, err := rm.ReadOne(ctx, latest)
rlog.Exit("rm.ReadOne", err)
if err != nil {
return latest, err
}

// Take the status from the latest ReadOne
latest.SetStatus(observed)

// Ensure that we are patching any changes to the annotations/metadata and
// the Spec that may have been set by the resource manager's successful
// Create call above.
Expand Down
2 changes: 2 additions & 0 deletions pkg/types/aws_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,6 @@ type AWSResource interface {
// SetIdentifiers will set the the Spec or Status field that represents the
// identifier for the resource.
SetIdentifiers(*ackv1alpha1.AWSIdentifiers) error
// SetStatus will set the Status field for the resource
SetStatus(AWSResource)
}