Skip to content

Conversation

@surajkota
Copy link
Contributor

Description of Changes

add adoptedresources, update to runtime 0.1.0

Testing

 PYTHONPATH=. pytest -n 5 --dist loadfile
=============================================== test session starts ================================================
platform linux -- Python 3.8.8, pytest-6.2.3, py-1.10.0, pluggy-0.13.1
rootdir: /home/ubuntu/go/src/github.com/aws-controllers-k8s/sagemaker-controller/test/e2e
plugins: xdist-2.2.0, forked-1.3.0, black-0.3.12
gw0 [26] / gw1 [26] / gw2 [26] / gw3 [26] / gw4 [26]
..........................                                                                                   [100%]
========================================= 26 passed in 1775.93s (0:29:35) ==========================================

Pending issues to be resolved

aws-controllers-k8s/community#755

@surajkota surajkota requested review from akartsky and removed request for RedbackThomson May 3, 2021 23:37
@akartsky
Copy link
Contributor

akartsky commented May 6, 2021

/approve

@akartsky
Copy link
Contributor

akartsky commented May 6, 2021

in the description and title it says update to runtime 0.1.0
but actually it is updated to 0.1.1 in code

@surajkota surajkota changed the title add adoptedresources, update to runtime 0.1.0 add adoptedresources, update to runtime 0.1.1 May 6, 2021
@surajkota
Copy link
Contributor Author

in the description and title it says update to runtime 0.1.0
but actually it is updated to 0.1.1 in code

good catch, yes there was a bug fix which was needed to make the feature fully functional

Copy link
Contributor

@mbaijal mbaijal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments otherwise LGTM.

@surajkota surajkota force-pushed the resource_adoption branch from 37e959a to d96ce30 Compare May 7, 2021 09:08
@surajkota
Copy link
Contributor Author

@mbaijal addressed comments

@surajkota surajkota force-pushed the resource_adoption branch from d96ce30 to a084696 Compare May 7, 2021 09:20
@surajkota surajkota force-pushed the resource_adoption branch from a084696 to 800bb6d Compare May 7, 2021 09:29
def name_suffix():
return random_suffix_name("sdk-endpoint", 32)

def sdk_make_model(model_name):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldnt these be fixtures ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually this is fine too.

@ack-bot
Copy link
Collaborator

ack-bot commented May 7, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akartsky, mbaijal, surajkota

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@surajkota surajkota merged commit 4e20e38 into aws-controllers-k8s:main May 7, 2021
ryansteakley pushed a commit to ryansteakley/sagemaker-controller that referenced this pull request May 17, 2021
ryansteakley pushed a commit to ryansteakley/sagemaker-controller that referenced this pull request May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants