-
Notifications
You must be signed in to change notification settings - Fork 41
add adoptedresources, update to runtime 0.1.1 #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add adoptedresources, update to runtime 0.1.1 #21
Conversation
|
/approve |
|
in the description and title it says update to |
good catch, yes there was a bug fix which was needed to make the feature fully functional |
mbaijal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments otherwise LGTM.
37e959a to
d96ce30
Compare
|
@mbaijal addressed comments |
d96ce30 to
a084696
Compare
a084696 to
800bb6d
Compare
| def name_suffix(): | ||
| return random_suffix_name("sdk-endpoint", 32) | ||
|
|
||
| def sdk_make_model(model_name): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldnt these be fixtures ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually this is fine too.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akartsky, mbaijal, surajkota The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of Changes
add adoptedresources, update to runtime 0.1.0
Testing
Pending issues to be resolved
aws-controllers-k8s/community#755