add canary related supporting infra #23
Conversation
| function cleanup { | ||
| echo "Cleaning up resources" | ||
| set +e | ||
| kubectl delete endpoints.sagemaker --all |
There was a problem hiding this comment.
this means we won't be able to run codebuild tests in parallel as one test might delete resources being used in another test.
Right now we don't need this as we don't have a problem of leaking resources.
By doing this we will not come to know if there are some leaking resources in future.
I think we should just handle these kinds of cleanup better in the the tests itself.
(this will help while running tests locally too as they might leave resources behind)
There was a problem hiding this comment.
there will some more work to make them run in parallel like not installing helm charts
lets keep this until then
There was a problem hiding this comment.
also there is the problem of finalizer where delete might get stuck forever
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akartsky, surajkota The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* helper scripts for canary * update acktest * buildspec and path changs * bug fix after rebase
* helper scripts for canary * update acktest * buildspec and path changs * bug fix after rebase
3 participants
Description
Scripts and build spec to run tests on existing EKS cluster using oidc and helm charts on codebuild
Testing
Using codebuild
Related PRs
aws-controllers-k8s/test-infra#18