Skip to content

Conversation

@sirutBuasai
Copy link
Member

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow
Copy link

ack-prow bot commented Nov 24, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ack-prow ack-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2025
@ack-prow ack-prow bot requested review from ananth102 and ryansteakley November 24, 2025 07:31
@sirutBuasai sirutBuasai marked this pull request as ready for review November 24, 2025 22:01
@ack-prow ack-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2025
@sirutBuasai sirutBuasai changed the title Update canary dependencies Update canary dependencies and fix inference component test Nov 24, 2025
@ack-prow
Copy link

ack-prow bot commented Nov 24, 2025

@sirutBuasai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
sagemaker-verify-code-gen 30fe5ab link false /test sagemaker-verify-code-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2025
@ack-prow
Copy link

ack-prow bot commented Nov 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelhtm, sirutBuasai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Nov 24, 2025
Comment on lines -251 to -261
# inference component transitions Updating -> InService state
assert_inference_component_status_in_sync(
reference.name,
reference,
cfg.INFERENCE_COMPONENT_STATUS_UPDATING,
)

assert k8s.wait_on_condition(
reference, ack_condition.CONDITION_TYPE_RESOURCE_SYNCED, "False"
)
assert k8s.get_resource_condition(reference, ack_condition.CONDITION_TYPE_TERMINAL) is None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed anymore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, SM hosting released a change where Updating -> InService status is fast tracked when failed artifacts are used

@ack-prow ack-prow bot merged commit 88c6dac into main Nov 24, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants