-
Notifications
You must be signed in to change notification settings - Fork 41
Update to ACK runtime v0.56.0, code-generator v0.56.0
#341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| jobs: | ||
| call-hydrate-go-proxy: | ||
| uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 days ago
To fix the problem, explicitly restrict the permissions granted to the GITHUB_TOKEN by adding a permissions block at the top (root) of the workflow file. The minimal and most secure default is permissions: {} (which disables all privileges except for metadata read), or more commonly permissions: contents: read, which is read-only access to repository contents. Since this workflow seems to only call a reusable workflow and does not perform any repository modifications itself, contents: read should suffice.
Specifically, add the following block just under the name key and above on: (e.g., between lines 1 and 3):
permissions:
contents: readNo additional method or import changes are needed—just this YAML edit.
-
Copy modified lines R2-R3
| @@ -1,4 +1,6 @@ | ||
| name: Hydrate Go Proxy | ||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| push: |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, ack-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test sagemaker-kind-e2e |
|
/retest |
|
@ack-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test sagemaker-kind-e2e |
Update to ACK runtime
v0.56.0, code-generatorv0.56.0v0.56.0release notesv0.56.0release notesNOTE:
This PR increments the release version of service controller from
v1.5.1tov1.6.0Once this PR is merged, release
v1.6.0will be automatically created forsagemaker-controllerPlease close this PR, if you do not want the new patch release for
sagemaker-controllerstdout for
make build-controller:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.