Skip to content

Conversation

@akartsky
Copy link
Contributor

@akartsky akartsky commented Mar 29, 2021

Upgrade to the latest version of AWS GoSDK.

This update includes the Artifactory Auth Support for Hosting

All integ tests passed

Copy link
Contributor

@RedbackThomson RedbackThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh great, this also includes environment variable support for training!

Copy link
Contributor

@mbaijal mbaijal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you sync with Suraj's changes as discussed ?

Copy link
Contributor

@surajkota surajkota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do NOT merge this PR as-is. Please rebase once #7 is merged and use the latest version(338d010225939a25b2e175594fec29b56707b388) of code generator and runtime 0.0.5

Also please git add files necessary for the PR

@akartsky akartsky force-pushed the update_version_1.38.7 branch from d325592 to cffec6f Compare April 2, 2021 17:05
@akartsky akartsky changed the title Upgrade AWS GoSDK version to v1.38.7 Upgrade AWS GoSDK version to v1.38.11 Apr 2, 2021
@akartsky
Copy link
Contributor Author

akartsky commented Apr 2, 2021

Do NOT merge this PR as-is. Please rebase once #7 is merged and use the latest version(338d010225939a25b2e175594fec29b56707b388) of code generator and runtime 0.0.5

Also please git add files necessary for the PR

Made all changes
ready to merge

@akartsky akartsky force-pushed the update_version_1.38.7 branch from cffec6f to dccb427 Compare April 6, 2021 23:24
@surajkota surajkota merged commit 41e4a1b into aws-controllers-k8s:main Apr 6, 2021
ryansteakley pushed a commit to ryansteakley/sagemaker-controller that referenced this pull request May 17, 2021
ryansteakley pushed a commit to ryansteakley/sagemaker-controller that referenced this pull request May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants