Skip to content

Conversation

@ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Nov 12, 2025

Update to ACK runtime v0.53.1, code-generator v0.53.1



NOTE:
This PR increments the release version of service controller from v1.2.2 to v1.2.3

Once this PR is merged, release v1.2.3 will be automatically created for sns-controller

Please close this PR, if you do not want the new patch release for sns-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building sns-controller ====
Copying common custom resource definitions into sns
Building Kubernetes API objects for sns
Generating deepcopy code for sns
Generating custom resource definitions for sns
Building service controller for sns
Running GO mod tidy
Generating RBAC manifests for sns
Running gofmt against generated code for sns
Updating additional GitHub repository maintenance files
==== building sns-controller release artifacts ====
Building release artifacts for sns-v1.2.3
Generating common custom resource definitions
Generating custom resource definitions for sns
Generating RBAC manifests for sns

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label Nov 12, 2025
@ack-prow ack-prow bot requested review from a-hilaly and rushmash91 November 12, 2025 23:14
@ack-prow
Copy link

ack-prow bot commented Nov 12, 2025

@ack-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
sns-verify-attribution 0467b44 link false /test sns-verify-attribution
sns-verify-code-gen 0467b44 link false /test sns-verify-code-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@michaelhtm
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2025
@ack-prow
Copy link

ack-prow bot commented Nov 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ack-bot, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Nov 13, 2025
@ack-prow ack-prow bot merged commit a97b92a into main Nov 13, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged. prow/auto-gen PRs related to prow auto generation automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants