-
Notifications
You must be signed in to change notification settings - Fork 22
Update to ACK runtime v0.54.1, code-generator v0.54.0
#103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ack-bot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
||
| jobs: | ||
| call-hydrate-go-proxy: | ||
| uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 8 days ago
To fix the problem, add a permissions block at the root of .github/workflows/postsubmit.yaml (recommended: sets minimum privilege for all jobs unless overridden), or specifically on the job. The safest root-level minimum for almost all use cases is contents: read. If your workflow or reusable workflow requires more, minimally expand permissions as necessary. Since your workflow simply calls another workflow via uses, start with contents: read. You can always adjust later if needed.
Steps:
- Add, under the workflow
nameline and beforeon:, apermissions: contents: readblock. - No other code, imports, or definitions are required.
-
Copy modified lines R2-R3
| @@ -1,4 +1,6 @@ | ||
| name: Hydrate Go Proxy | ||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| push: |
|
@ack-bot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/close |
|
@knottnt: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Update to ACK runtime
v0.54.1, code-generatorv0.54.0v0.54.0release notesv0.54.1release notesNOTE:
This PR increments the release version of service controller from
v1.2.3tov1.2.4Once this PR is merged, release
v1.2.4will be automatically created forsns-controllerPlease close this PR, if you do not want the new patch release for
sns-controllerstdout for
make build-controller:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.