fix(subscription): handle nil RawMessageDelivery in delta comparison
#62
Conversation
The change adds a custom pre comparison hook for the Subscription resource to handle cases where `RawMessageDelivery` is nil in the source object. This prevents unnecessary updates when only the `RawMessageDelivery` field differs in nil/non-nil status but represents the same effective configuration.
|
@a-hilaly: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
Fixes aws-controllers-k8s/community#2195
The change adds a custom pre comparison hook for the Subscription resource
to handle cases where
RawMessageDeliveryis nil in the source object. Thisprevents unnecessary updates when only the
RawMessageDeliveryfield differsin nil/non-nil status but represents the same effective configuration.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.