Skip to content

fix(subscription): handle nil RawMessageDelivery in delta comparison #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2024
Merged

fix(subscription): handle nil RawMessageDelivery in delta comparison #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apis/v1alpha1/ack-generate-metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
ack_generate_info:
build_date: "2024-10-10T04:06:54Z"
build_date: "2024-10-24T02:01:48Z"
build_hash: 36c2d234498c2bc4f60773ab8df632af4067f43b
go_version: go1.23.2
version: v0.39.1
api_directory_checksum: bcc8c2cf96b31122dc6ff2654d065e3bbd8f0c33
api_directory_checksum: ca04ac625e016be719b2899d653c5c11451ccb40
api_version: v1alpha1
aws_sdk_go_version: v1.49.0
generator_config_info:
file_checksum: e8c9e140ef5690daab43e5452645acfd993dc678
file_checksum: d3bd4b1ffa6fe007058950b96d686a4b344b3b8d
original_file_name: generator.yaml
last_modification:
reason: API generation
2 changes: 2 additions & 0 deletions apis/v1alpha1/generator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,8 @@ resources:
template_path: hooks/subscription/sdk_create_post_build_request.go.tpl
sdk_get_attributes_pre_set_output:
template_path: hooks/subscription/sdk_get_attributes_pre_set_output.go.tpl
delta_pre_compare:
code: customPreCompare(delta, a, b)
fields:
ConfirmationWasAuthenticated:
is_attribute: true
Expand Down
2 changes: 2 additions & 0 deletions generator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,8 @@ resources:
template_path: hooks/subscription/sdk_create_post_build_request.go.tpl
sdk_get_attributes_pre_set_output:
template_path: hooks/subscription/sdk_get_attributes_pre_set_output.go.tpl
delta_pre_compare:
code: customPreCompare(delta, a, b)
fields:
ConfirmationWasAuthenticated:
is_attribute: true
Expand Down
1 change: 1 addition & 0 deletions pkg/resource/subscription/delta.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions pkg/resource/subscription/hooks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,3 +156,9 @@ func (rm *resourceManager) newSetAttributesRequestPayload(
}
return res
}

func customPreCompare(delta *ackcompare.Delta, a, b *resource) {
if a.ko.Spec.RawMessageDelivery == nil {
a.ko.Spec.RawMessageDelivery = b.ko.Spec.RawMessageDelivery
}
}