add loggingconfig support for webacl resource #29
Conversation
rushmash91
force-pushed
the
loggingconfig
branch
7 times, most recently
from
39daeb2 to
301e536
Compare
| if loggingConfigResp != nil && loggingConfigResp.LoggingConfiguration != nil { | ||
| // Populate the logging configuration fields in ko. | ||
| if errSetLogCfg := setLoggingConfiguration(ko, loggingConfigResp.LoggingConfiguration); errSetLogCfg != nil { | ||
| return nil, errSetLogCfg | ||
| } | ||
| } |
There was a problem hiding this comment.
genuine question why use errGetLogCfg and errGetLogCfg as error names, it's pretty rare in Go to see such a name decision
There was a problem hiding this comment.
I was using the debugger to look at the err variables, had renamed them to have all of them at a checkpoint. Switched back to err.
michaelhtm
left a comment
michaelhtm
left a comment
There was a problem hiding this comment.
Great work @rushmash91
left a few nits
rushmash91
force-pushed
the
loggingconfig
branch
3 times, most recently
from
04c9a41 to
53b3792
Compare
|
/lgtm |
ack-prow
bot
added
do-not-merge/hold
|
@rushmash91: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
knottnt
left a comment
knottnt
left a comment
There was a problem hiding this comment.
Small nit about logging.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knottnt, michaelhtm, rushmash91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
ack-prow
bot
removed
the
do-not-merge/hold
4 participants
Closes aws-controllers-k8s/community#2439
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.