chore: use pytest automatic color output detection #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Usiskin <56369778+jusiskin@users.noreply.github.com>
|
moorec-aws
approved these changes
Oct 16, 2024
ddneilson
approved these changes
Oct 16, 2024
YutongLi291
pushed a commit
to YutongLi291/deadline-cloud-worker-agent-fork
that referenced
this pull request
Oct 16, 2024
Signed-off-by: Josh Usiskin <56369778+jusiskin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The
deadline-cloud-worker-agentrepository had a configuration setting to force use console color output. This was done to ensure pytest output is colorized in GitHub actions (see pytest-dev/pytest#7462 and actions/runner#241 for background on this issue).Forcing color output negatively impacts legibility in CodeBuild where we run our integration and e2e tests.
What was the solution? (How)
Remove the configuration in
pyproject.tomlto force colorized pytest output. Legibility is more important than colorized output.What is the impact of this change?
Test output is more legible in CodeBuild and GitHub actions will no longer have colorized output. There is no change for running tests in a terminal. Pytest correctly detects the terminal and colorizes output.
How was this change tested?
Ran the tests with:
The tests succeed and are colorized locally
Was this change documented?
No
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.