feat: agent core runtime + runtime endpoint #5
Conversation
|
Hi there, I am commenting because your project has not yet been published and you have opened a pr to the If you are ready to publish, please issue the following comment on this PR and I will initiate the publication review
If you require more information please reach out to your AWS contact assisting you with this project. |
|
/do-e2e-tests |
|
End to end test has been scheduled |
|
E2E tests in progress |
![aws-ia-automator-prod[bot]](https://avatars.githubusercontent.com/u/149281641?s=60&v=4){kind=small}
|
/do-e2e-tests |
|
End to end test has been scheduled |
|
E2E tests in progress |
1 similar comment
|
E2E tests in progress |
|
/confirm-publication |
Co-authored-by: Scott Schreckengaust <scottschreckengaust@users.noreply.github.com>
dineshSajwan
left a comment
dineshSajwan
left a comment
There was a problem hiding this comment.
Looks good, approving it but have some suggestion for the documentation.
| - **IAM Role Management**: Automatic creation of IAM roles with appropriate permissions | ||
| - **Environment Variables**: Pass configuration to your runtime container | ||
| - **JWT Authorization**: Optional JWT authorizer configuration for secure access | ||
| - **Endpoint Management**: Create and manage runtime endpoints for client access |
There was a problem hiding this comment.
It will be good if we can add more details about endpoint management. How the default endpoint is created and how you can leverage endpoint to point to specific version. You can refer here - https://github.com/aws/aws-cdk/blob/150b222669d997c7bc10270a27bacf498b2c282a/packages/%40aws-cdk/aws-bedrock-agentcore-alpha/README.md#managing-endpoints-and-versions
| } | ||
| ``` | ||
|
|
||
| ### With JWT Authorization |
There was a problem hiding this comment.
We should mention that if no runtime_authorizer_configuration is there then by default underlying service use I AM. Also are we not supporting oAuth for now ? - https://github.com/krokoko/agent-core-cdk-constructs/blob/5e4b3cdcb5a181d1710795d9314263aab42fc267/src/cdk-lib/bedrock-agentcore/runtime/runtime.ts#L753
alexa-perlov
dismissed stale reviews from dineshSajwan and scottschreckengaust
via
32eb076
|
/do-e2e-tests |
|
End to end test has been scheduled |
|
E2E tests in progress |
1 similar comment
|
E2E tests in progress |
3 participants
No description provided.