Add tag conversion support #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewmullen
approved these changes
Nov 18, 2021
Contributor
drewmullen
left a comment
drewmullen
left a comment
There was a problem hiding this comment.
fantastic work. thank you for your contribution
andrew-glenn
approved these changes
Nov 18, 2021
Contributor
|
Looks awesome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested before this pr adds support for both aws and awscc provider tagging format to the module.
The new functionality is demonstrated in
examples/formatted_tags/main.tfwhere tags is passed in both formats and outputted in both formats. I have taken the liberty to create aninternalsfolder for things that shouldn't be use in the module. I also added a limitedMakefilesince it was nice to have during development.