Skip to content

Update kernels to match current tutorials#118

Merged
erickson-doug merged 4 commits intomainfrom
clm/update-samples
Feb 10, 2026
Merged

Update kernels to match current tutorials#118
erickson-doug merged 4 commits intomainfrom
clm/update-samples

Conversation

@mrkcath-aws
Copy link
Contributor

@mrkcath-aws mrkcath-aws commented Feb 9, 2026

Remove tutorial kernels that do not have corresponding documentation pages:

  • softmax (softmax_nki_kernels.py, softmax_torch.py)
  • rotary (rotary_nki_kernels.py)

Add mxfp-matmul tutorial which has dedicated documentation.

Issue #, if available:

N/A

Description of changes:

Remove tutorial kernels that do not have corresponding documentation pages:

  • softmax (softmax_nki_kernels.py, softmax_torch.py)
  • rotary (rotary_nki_kernels.py)

Add mxfp-matmul tutorial which has dedicated documentation

Testing:

Please see detailed unit test requirements in the CONTRIBUTING.md

  • [ N/A ] The change is covered by numeric check using nki.baremetal
  • [ N/A ] The change is covered by performance benchmark test using nki.benchmark
  • [ N/A ] The change is covered by end-to-end integration test

Pull Request Checklist

  • [ X ] I have filled in all the required field in the template
  • [ X ] I have tested locally that all the tests pass
  • [ X ] By submitting this pull request, I confirm that my contribution is made under the terms of the MIT-0 license.

Remove tutorial kernels that do not have corresponding documentation pages:
- softmax (softmax_nki_kernels.py, softmax_torch.py)
- rotary (rotary_nki_kernels.py)
- attention_fwd_performance (attention_kernels.py, test_attention.py)

Add mxfp-matmul tutorial which has dedicated documentation.
erickson-doug
erickson-doug previously approved these changes Feb 9, 2026
Remove the reference kernels section from README as these kernels
are no longer maintained in this repository. Delete associated
documentation files, RST references, and image assets that are
no longer needed.

The tutorial kernels remain as the primary educational resource
for NKI samples.
aws-serina-tan
aws-serina-tan previously approved these changes Feb 9, 2026
erickson-doug
erickson-doug previously approved these changes Feb 10, 2026
Copy link
Contributor

@aws-qieqingy aws-qieqingy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erickson-doug erickson-doug merged commit 6905a68 into main Feb 10, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants