-
Notifications
You must be signed in to change notification settings - Fork 98
chore(v2): Split powertools idempotency module (without redis impl) #1559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It's not clear to me if |
801edf2 to
6f214c2
Compare
💾 Artifacts Size Report
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## v2 #1559 +/- ##
=====================================
Coverage ? 89.79%
Complexity ? 406
=====================================
Files ? 44
Lines ? 1274
Branches ? 165
=====================================
Hits ? 1144
Misses ? 88
Partials ? 42 ☔ View full report in Codecov by Sentry. |
478e790 to
6a3be41
Compare
6a3be41 to
f5928ec
Compare
|
jeromevdl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK



Issue #, if available:
#1504
Description of changes:
Takes @eldimi 's changes from #1513 for the module split only. I've rebased the commits from
0ec7f4a0d7424c24cb402f23f6896111f257ac44to6da6aaf6b558edb56b18dd71e2f0ed1a7a8d8d13inclusive onto v2. We will merge this and take the redis implementation in later.Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.