improv(parameters): Make parameters utility thread-safe #2284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r cache and transformer management.
|
phipag
moved this from Working on it
to Pending review
in Powertools for AWS Lambda (Java)
2 tasks
svozza
approved these changes
Nov 13, 2025
github-project-automation
bot
moved this from Pending review
to Coming soon
in Powertools for AWS Lambda (Java)
phipag
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the Parameters utility including all providers thread-safe. This means, they can now safely be used from multi-threaded scenarios (e.g. parallel batch processing). The cache is also thread-safe and propagates across threads.
Changes
The core changes required are in the
BaseProvider,CacheManger, andTransformationManager. Due to the fluent API using method chaining, methods such as.withMaxAge(...).get("key")led to two separate instructions which can cause race conditions in multi-threaded scenarios.The solution used in this PR is to use
ThreadLocalorAtomic*data structures where appropriate and we add thread-safety with zerosynchronizedstatements. Unit tests are added to test for thread-safety.Issue number: #2283
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.