fix: Minor static analysis code fixes #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msailes
reviewed
Aug 18, 2020
|
|
||
| public static void setFinalField(Class<LambdaHandlerProcessor> className, String fieldName, Object value) throws IllegalAccessException { | ||
| Field field = FieldUtils.getField(className, fieldName, true); | ||
| FieldUtils.removeFinalModifier(field); |
Contributor
Author
There was a problem hiding this comment.
Although lol it seems you cannot do this post java 12+. Too bad :D
Contributor
Author
There was a problem hiding this comment.
I like that we can build in forward compatible way
msailes
previously approved these changes
Aug 18, 2020
pankajagrawal16
force-pushed
the
static-fixes
branch
from
a716b79 to
2a57414
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.