feat: Powertools will now override the Log4J log level configured if … #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajagrawal16
approved these changes
Aug 18, 2020
Contributor
pankajagrawal16
left a comment
pankajagrawal16
left a comment
There was a problem hiding this comment.
One suggestion, else looks neat 🎉
| @Aspect | ||
| public final class LambdaLoggingAspect { | ||
| private static final ObjectMapper mapper = new ObjectMapper(); | ||
| private static final String LOG_LEVEL = System.getenv("LOG_LEVEL"); |
Contributor
There was a problem hiding this comment.
Should we use a example in one of the sample lambda function in example folder ?
Contributor
Contributor
Author
There was a problem hiding this comment.
Yes, lets merge #41 first, then re-review this.
Contributor
There was a problem hiding this comment.
Yes sure. You can take it as another PR as well, fine by me.
pankajagrawal16
force-pushed
the
log-level-env-var
branch
from
2b657a5 to
4a5a11b
Compare
Contributor
|
hmm what just happend.. i just tried rebasing 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…the 'LOG_LEVEL' environment variable is set to a Log4J Level (INFO, ERROR etc...)
Issue #, if available:
Description of changes:
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.