Skip to content

fix(gradle): Fix gradle example and docs to work with java 12+ #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 10, 2022
Merged

fix(gradle): Fix gradle example and docs to work with java 12+ #703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ab83f6
fix(gradle): Fix gradle example and docs to work with java 12+
michaelbrewer Jan 10, 2022
07aa1d8
Merge branch 'master' into fix-gradle-docs-example
michaelbrewer Jan 10, 2022
c0106e0
fix: no need to include implementation
michaelbrewer Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,9 @@ For more information about the project and available options refer to this [repo
aspect 'software.amazon.lambda:powertools-tracing:{{ powertools.version }}'
aspect 'software.amazon.lambda:powertools-metrics:{{ powertools.version }}'
}

sourceCompatibility = 11
targetCompatibility = 11
```

## Environment variables
Expand Down
32 changes: 12 additions & 20 deletions example/HelloWorldFunction/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,36 +1,28 @@
plugins{
id 'java'
id 'aspectj.AspectjGradlePlugin' version '0.0.7'
id 'io.freefair.aspectj.post-compile-weaving' version '6.3.0'
}

repositories {
mavenCentral()
}

dependencies {
implementation 'software.amazon.lambda:powertools-tracing:1.10.2'
aspectpath 'software.amazon.lambda:powertools-tracing:1.10.2'

implementation 'software.amazon.lambda:powertools-logging:1.10.2'
aspectpath 'software.amazon.lambda:powertools-logging:1.10.2'

implementation 'software.amazon.lambda:powertools-metrics:1.10.2'
aspectpath 'software.amazon.lambda:powertools-metrics:1.10.2'

implementation 'software.amazon.lambda:powertools-sqs:1.10.2'
aspectpath 'software.amazon.lambda:powertools-sqs:1.10.2'

implementation 'software.amazon.lambda:powertools-parameters:1.10.2'
aspectpath 'software.amazon.lambda:powertools-parameters:1.10.2'

implementation 'software.amazon.lambda:powertools-validation:1.10.2'
aspectpath 'software.amazon.lambda:powertools-validation:1.10.2'
aspect 'software.amazon.lambda:powertools-logging:1.10.2'
aspect 'software.amazon.lambda:powertools-tracing:1.10.2'
aspect 'software.amazon.lambda:powertools-metrics:1.10.2'
aspect 'software.amazon.lambda:powertools-sqs:1.10.2'
aspect 'software.amazon.lambda:powertools-parameters:1.10.2'
aspect 'software.amazon.lambda:powertools-validation:1.10.2'

implementation 'com.amazonaws:aws-lambda-java-core:1.2.1'
implementation 'com.amazonaws:aws-lambda-java-events:3.1.0'

implementation 'org.apache.logging.log4j:log4j-api:2.16.0'
implementation 'org.apache.logging.log4j:log4j-core:2.16.0'

testImplementation 'junit:junit:4.12'
}
testImplementation 'junit:junit:4.13.2'
}

sourceCompatibility = 11
targetCompatibility = 11
2 changes: 1 addition & 1 deletion example/HelloWorldFunction/gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-6.8.2-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-7.3.3-bin.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
2 changes: 1 addition & 1 deletion example/HelloWorldFunction/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>4.13.1</version>
<version>4.13.2</version>
<scope>test</scope>
</dependency>
</dependencies>
Expand Down