Skip to content

Conversation

@ijemmy
Copy link
Contributor

@ijemmy ijemmy commented Dec 28, 2021

Description of your changes

  • Rename version develop to main
  • When release, it will have the release version (e.g. 0.1.0 ) with the alias latest. It also set latest as the default version when user go to the root.

How to verify this change

I verified by changing the target trigger branch and push my change there. The run was green and new version of doc has been published.

Related issues, RFCs

PR status

Is this ready for review?: NO
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@saragerion saragerion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

@ijemmy ijemmy merged commit 9f45ee1 into main Dec 28, 2021
@ijemmy ijemmy deleted the feat/gen-doc-on-release branch December 28, 2021 13:47
python-version: '3.8'
- name: Set RELEASE_VERSION env var
run: |
RELEASE_VERSION=$(cat packages/commons/package.json | jq '.version' -r)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure it's going to work ... this version will be the one before ... the on-release workflow will bump the version and push a new commit with the new version in package.json as well as a corresponding git tag. And this commit skip ci to avoid infinite loop ... I think we should make this run only if the on-release succeed or move those jobs in the on-release workflow

@heitorlessa heitorlessa added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants