-
Notifications
You must be signed in to change notification settings - Fork 180
feat: generate new version of doc for each release #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…+ rename develop version to main
…the existing version
saragerion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dreamorosi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
| python-version: '3.8' | ||
| - name: Set RELEASE_VERSION env var | ||
| run: | | ||
| RELEASE_VERSION=$(cat packages/commons/package.json | jq '.version' -r) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure it's going to work ... this version will be the one before ... the on-release workflow will bump the version and push a new commit with the new version in package.json as well as a corresponding git tag. And this commit skip ci to avoid infinite loop ... I think we should make this run only if the on-release succeed or move those jobs in the on-release workflow
Description of your changes
developtomain0.1.0) with the aliaslatest. It also setlatestas the default version when user go to the root.How to verify this change
I verified by changing the target trigger branch and push my change there. The run was green and new version of doc has been published.
Related issues, RFCs
PR status
Is this ready for review?: NO
Is it a breaking change?: NO
Checklist
Breaking change checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.