Skip to content

Conversation

@dreamorosi
Copy link
Contributor

Description of your changes

This PR supersedes:
#341
#343
#345
#346
#357

How to verify this change

Check that github activities run successfully, optionally checkout branch & run e2e tests.

Related issues, RFCs

N/A

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally and in Github Actions
  • The PR title follows the conventional commit semantics

Breaking change checklist

N/A


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi self-assigned this Dec 30, 2021
@dreamorosi dreamorosi added dependencies Changes that touch dependencies, e.g. Dependabot, etc. javascript labels Dec 30, 2021
@dreamorosi dreamorosi added this to the beta-release milestone Dec 30, 2021
@dreamorosi dreamorosi requested review from flochaz and ijemmy December 30, 2021 09:58
saragerion
saragerion previously approved these changes Dec 30, 2021
Copy link
Contributor

@flochaz flochaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good now that we have cdk back in

@dreamorosi dreamorosi merged commit 756f475 into main Dec 30, 2021
@dreamorosi dreamorosi deleted the deps/bump_metrics_deps branch December 30, 2021 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Changes that touch dependencies, e.g. Dependabot, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants