Skip to content

improv(event-handler): ended response stream when body is null #4651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2025
Merged

improv(event-handler): ended response stream when body is null #4651

merged 1 commit into from
Oct 16, 2025

Conversation

@sdangol
Copy link
Contributor

@sdangol sdangol commented Oct 16, 2025 •
edited
Loading

Summary

This PR ends the response stream when the body of the handler is null

Changes

Please provide a summary of what's being changed

  • Added resStream.end(); after resStream.write('');

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #4650

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added the event-handler This item relates to the Event Handler Utility label Oct 16, 2025
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Oct 16, 2025
@sdangol sdangol self-assigned this Oct 16, 2025
@sdangol sdangol requested a review from svozza October 16, 2025 12:59
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sdangol sdangol changed the title improv(event-handler): Ended Response Stream when body is null improv(event-handler): ended response stream when body is null Oct 16, 2025
@sdangol sdangol merged commit a37a317 into main Oct 16, 2025
45 checks passed
@sdangol sdangol deleted the fix/end-res-stream branch October 16, 2025 13:07
svozza
svozza reviewed Oct 16, 2025
View reviewed changes
Copy link
Contributor

@svozza svozza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update a null body test to check that this method has been called maybe using spyOn or somethingthe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@svozza svozza svozza left review comments

@dreamorosi dreamorosi dreamorosi approved these changes

Assignees

@sdangol sdangol

Labels

event-handler This item relates to the Event Handler Utility size/XS PR between 0-9 LOC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Maintenance: End the Response Stream when body is null in #streamHandlerResponse

3 participants

@sdangol @dreamorosi @svozza