Skip to content

Conversation

@svozza
Copy link
Contributor

@svozza svozza commented Oct 23, 2025

Summary

Tte InvokeStore dependency added in #4658, is packaged as a CJS module and because it uses a Node API (node:async_hooks), this causes problems for ESBuild when it tries to bundle to ESM.

We must revert #4658 and #4663 as they both use InvokeStore.

Changes

Issue number: closes #4677


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@svozza svozza requested a review from sdangol October 23, 2025 12:06
@boring-cyborg boring-cyborg bot added commons This item relates to the Commons Utility dependencies Changes that touch dependencies, e.g. Dependabot, etc. metrics This item relates to the Metrics Utility tests PRs that add or change tests labels Oct 23, 2025
@pull-request-size pull-request-size bot added the size/XXL PRs with 1K+ LOC, largely documentation related label Oct 23, 2025
@sonarqubecloud
Copy link

@svozza svozza changed the title bug(logger): fix esbuild ESM bundler error fix(logger): fix esbuild ESM bundler error Oct 23, 2025
@svozza
Copy link
Contributor Author

svozza commented Oct 23, 2025

E2E tests have passed: https://github.com/aws-powertools/powertools-lambda-typescript/actions/runs/18748386048

@svozza svozza added do-not-merge This item should not be merged and removed do-not-merge This item should not be merged labels Oct 23, 2025
@svozza svozza merged commit 8a13e8e into main Oct 23, 2025
100 of 102 checks passed
@svozza svozza deleted the invoke-store-fix-await branch October 23, 2025 15:45
@svozza svozza self-assigned this Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commons This item relates to the Commons Utility dependencies Changes that touch dependencies, e.g. Dependabot, etc. metrics This item relates to the Metrics Utility size/XXL PRs with 1K+ LOC, largely documentation related tests PRs that add or change tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Bundling with esbuild (format ESM) fails with version >=2.28

2 participants