test(maintenance): remove unnecessary esbuild banner from e2e tests #4745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XL
svozza
changed the title
svozza
changed the title
svozza
force-pushed
the
testing/remove-esbuild-banner-e2e
branch
from
c345d5f to
783cdc0
Compare
|
svozza
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the end-to-end tests to remove the ESBuild banner that is added by default. This banner is only needed when we are consuming packages that only ship CommonJS arfifacts and bundling to ESM. For utilities that do not consume packaes like this we should not add this banner as it can lead to inadvertent breaking changes being missed such as: #4677.
Changes
Tracer) to run all it's tests in both CJS and ESM.describe.eachto run the Tracer tests in both ESM and CJS format changed the indentation.Testing
Issue number: closes #4715
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.