feat(event-handler): add support for ALB #4759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XL
boring-cyborg
bot
added
event-handler
svozza
force-pushed
the
event-hanlder/alb-support
branch
from
024bfe3 to
e88ed90
Compare
svozza
force-pushed
the
event-hanlder/alb-support
branch
from
e88ed90 to
1cf1cf8
Compare
sdangol
reviewed
Nov 17, 2025
svozza
force-pushed
the
event-hanlder/alb-support
branch
from
98717a2 to
e78f578
Compare
Contributor
Author
|
The SonarQube warning is from a piece of code I haven't touched. |
Contributor
You're right - it checks the file I think. If possible, still address it please. |
Contributor
Author
|
TIL about |
svozza
force-pushed
the
event-hanlder/alb-support
branch
from
e78f578 to
7b11fcb
Compare
|
dreamorosi
approved these changes
Nov 17, 2025
Contributor
dreamorosi
left a comment
dreamorosi
left a comment
There was a problem hiding this comment.
PR looks good to me, thanks for this!
For the HttpStatusCodes review comment, I would've agreed with @sdangol's proposal but I can see the argument you made about complexity. I'm ambivalent about keeping this way or changing it so I'll leave the decision to you two.
Once the comments are resolved (either way), feel free to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for ALB lambda integrations, as with the other implementations, the router autodetects the event type and returns the appropriate response.
Changes
Requestconversion functionResponseconversion functiondescriptionStatusfield correctlyTesting
describe.eachblock in routing testsstatusDescriptionfieldIssue number: closes #4758
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.