generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 181
feat(idempotency): Allow durable function to replay #4834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+115
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamorosi
requested changes
Dec 2, 2025
dreamorosi
requested changes
Dec 2, 2025
|
dreamorosi
approved these changes
Dec 2, 2025
Contributor
dreamorosi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Contributor
Author
|
I've opened #4839 to track the E2E test task |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
idempotency
This item relates to the Idempotency Utility
size/L
PRs between 100-499 LOC
tests
PRs that add or change tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Summary
This PR adds support for Durable Functions to the Idempotency Utility.
In testing, we discovered that the Idempotency utility did not work with Durable Functions when they suspended and replayed. This is because the replay appeared like a duplicate, so raised an
IdempotencyAlreadyInProgressErrorWe use the
DurableModeproperty on theDurableContextobject to track if this is a new execution, or a replay of an prior execution.The behaviour of the handler is the same, except when it's a previously seen payload "in progress" and the
DurableModeisREPLAY_MODE. Then the execution will continue, where previously it would have raised the errorIdempotencyAlreadyInProgressErrorChanges
makeIdempotent. If it's a durable context, extract the lambda context and theDurableMode.IdempotentHandler.handler()method,durableMode.IdempotentHandlerto check if the execution is inREPLAY_MODEwhenIdempotencyAlreadyInProgressErroris thrown.IdempotentHandler.test.jsmakeIdempotent.test.jsNotes
Issue number: closes #4831
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.