Relax PyYAML version requirement #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why it was requiring a specific version, but doesn't seem to be necessary. Update setup.sh Don't deactivate virtual venv because it can be setting up newer python version. Use return instead of exit so don't exit calling shell. Use "which node" instead of "node -v" to detect if nodejs is in the path. "node-v" prompts to install nodejs, which I don't want because I want control over which version is installed. Add to documentation on how to use newer versions of python. Resolves #212
cartalla
force-pushed
the
212-pyyaml-541-in-sourcerequirementstxt-does-not-install-due-to-release-of-cython30
branch
from
dd4d994 to
2191bf1
Compare
cartalla
deleted the
212-pyyaml-541-in-sourcerequirementstxt-does-not-install-due-to-release-of-cython30
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why it was requiring a specific version, but doesn't seem to be necessary.
Update setup.sh
Don't deactivate virtual venv because it can be setting up newer python version.
Use return instead of exit so don't exit calling shell.
Use "which node" instead of "node -v" to detect if nodejs is in the path. "node-v" prompts to install nodejs, which I don't want because I want control over which version is installed.
Resolves #212
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.