Add config options for extra security groups and iam policies for hea… #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartalla
commented
May 8, 2024
cartalla
force-pushed
the
225-feature-add-custom-iam-policies-and-security-groups-for-head-and-compute-nodes
branch
from
7cd9df3 to
6e9f224
Compare
cartalla
commented
May 8, 2024
…d and compute nodes Add the following config options: * slurm/ParallelClusterConfig/ClusterConfig * slurm/SlurmCtl/AdditionalSecurityGroups * slurm/SlurmCtl/AdditionalIamPolicies * slurm/SlurmCtl/Imds/Secured * slurm/InstanceConfig/AdditionalSecurityGroups * slurm/InstanceConfig/AdditionalIamPolicies Added documentation for all config parameters. Changed the StackName default from slurm-top to slurm-config. Fix the slurm/ParallelClusterConfig/Dcv/Enabled option. Change the option name from Enable to Enabled to match ParallelCluster. Fix the setting of ParallelCluster HeadNode/Dcv/AllowedIps config Was setting from non-existent slurm/ParallelClusterConfig/AllowedIps instead of slurm/ParallelClusterConfig/HeadNode/Dcv/AllowedIps. Delete the following config option because it uses legacy cluster. * slurm/EdfaSlurmClusterStackName Resolves #225
cartalla
force-pushed
the
225-feature-add-custom-iam-policies-and-security-groups-for-head-and-compute-nodes
branch
from
6e9f224 to
7d89893
Compare
cartalla
deleted the
225-feature-add-custom-iam-policies-and-security-groups-for-head-and-compute-nodes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d and compute nodes
Add the following config options:
Added documentation for all config parameters.
Changed the StackName default from slurm-top to slurm-config.
Fix the slurm/ParallelClusterConfig/Dcv/Enabled option. Change the option name from Enable to Enabled to match ParallelCluster.
Fix the setting of ParallelCluster HeadNode/Dcv/AllowedIps config Was setting from non-existent slurm/ParallelClusterConfig/AllowedIps instead of slurm/ParallelClusterConfig/HeadNode/Dcv/AllowedIps.
Delete the following config option because it uses legacy cluster.
Resolves #225
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.