Skip to content
Merged

Fix/JS #1016

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/deployments/cdk/src/apps/phase-1.ts
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,7 @@ export async function deploy({ acceleratorConfig, accountStacks, accounts, conte
accountIamConfigs[accountKey].users = iamConfig.users;
}
} else {
accountIamConfigs[accountKey] = iamConfig;
accountIamConfigs[accountKey] = IamConfigType.encode(JSON.parse(JSON.stringify(iamConfig)));
}
}

Expand Down
8 changes: 4 additions & 4 deletions src/deployments/cdk/src/common/iam-assets.ts
Original file line number Diff line number Diff line change
Expand Up @@ -244,14 +244,14 @@ export class IamAssets extends cdk.Construct {
return iamSSMLogArchiveReadOnlyAccessPolicy;
};

if (!IamConfigType.is(iamConfig)) {
if (!iamConfig) {
console.log(
`IAM config is not defined for account with key - ${accountKey}. Skipping Policies/Users/Roles creation.`,
);
} else {
const iamPolicies = iamConfig.policies;
for (const iamPolicy of iamPolicies!) {
if (!IamPolicyConfigType.is(iamPolicy)) {
if (!iamPolicy) {
console.log(
`IAM config - policies is not defined for account with key - ${accountKey}. Skipping Policies creation.`,
);
Expand All @@ -262,7 +262,7 @@ export class IamAssets extends cdk.Construct {

const iamUsers = iamConfig.users;
for (const iamUser of iamUsers!) {
if (!IamUserConfigType.is(iamUser)) {
if (!iamUser) {
console.log(
`IAM config - users is not defined for account with key - ${accountKey}. Skipping Users creation.`,
);
Expand All @@ -287,7 +287,7 @@ export class IamAssets extends cdk.Construct {
: undefined;

for (const iamRole of iamRoles) {
if (!IamRoleConfigType.is(iamRole)) {
if (!iamRole) {
console.log(
`IAM config - roles is not defined for account with key - ${accountKey}. Skipping Roles creation.`,
);
Expand Down