(enhancement): Adjust the Throttle Backoff setting delayFirstAttempt to false #1077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brian969
approved these changes
Oct 20, 2022
Contributor
Brian969
left a comment
Brian969
left a comment
There was a problem hiding this comment.
LGTM - delayfirstattempt impact was unexpected.
wrnu
pushed a commit
to wrnu/aws-secure-environment-accelerator
that referenced
this pull request
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
When delayFirstAttempt is set to true, a random wait is added for all calls. This has increased State Machine processing time and 'Add Tags to Shared Resources' may now timeout. This PR switches the delayFirstAttemp to false.
Below are the AddTagsToSharedResource processing times:
v1.5.3:
v1.5.4:
This PR:
