Skip to content

Conversation

@Kevinwochan
Copy link
Contributor

@Kevinwochan Kevinwochan commented Feb 5, 2024

Issue number:
#27

Summary

  • Branch hygiene

Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

igorlg and others added 30 commits September 14, 2023 10:48
* updating minor versions of dependencies

* updated contracts sam template

* deployable sam template

* implemented without testing

* deployable openapi spec for unicorn_web

* added stephens tamplte

* working OpenAPI endpoint

* fix typo

* consistent naming of log group

* shuffling roles for apigw

* commented out stephen's WIP policy

* implementing queries

* working create contracts

* cleanup

* feat: updated contracts impl

* feat: updated web impl

* feat: updates to Properties

* chore: updated template for properties

* fix: updated property data

* chore: removed vscode settings

* chore: updated Stage values to lower case and references; update ssm params; updated templates and api

* fix: remove old samconfig file

* sub policies unicorn_contracts

* sub templates unicorn_prop

* sub templates for unicorn_web

* workign unicorn_contracts tempalte

* bumping packages

* added sub policies to samconfig

* fixed sub policies reference

* updated sam config for unicorn_properties

* consistent casing

* naming and tsdocs

* working event pipe

* working unicorn_properties

* working unicorn web

* added makefiles

* WIP: unicorn contracts testing

* fix: syncing changes with .net

* using = operator for update contracts

* python integration tests

* updated gitignores for python

* adding testing to workflow

* fix: updated workflow

* fix: typo

* removed python unit tests

* disabling unciorn_properties and unciorn_web

* added shared infrastructure

* disabling fast fail

* poertry for integration tests

* fix: working dir

* deploying shared infrastructure

* needs job

* checkout for shared infra

* removing SSM parameters from servies

* added npm script for deploy

* renaming shared infra file

* merging

* unicorn_properties integration tests

* updated casing for ddb key

* unicorn_web integration test

* restoring TS function metadata

* feat: added shared resources

* chore: update subscriber-policies and subscriptions

* chore: synced templates with latest py and .NET

* chore: template updates

* refactor: removed sfn task token validation

* fix: typos in importing template

* test: python integration tests

* test: adding testing to workflow

* fix: updated workflow

* fix: typo

* test: removed python unit tests

* test: poertry for integration tests

* fix: working dir

* test: unicorn_properties integration tests

* test: unicorn_web integration test

* fix: removed sfn task token validation

* fix: typos in importing template

* chore: updated from dotnet

* chore: restoring Eventbus to output for integration test

* fixes: post merge conflict

* fix: runtime fix after merge

* typo: changing to contracts

* chore: synced with python templates

* fix: post python sync

* test: implemented integration tests for unicorn web

* deleted helper test script

* test: rename API endpoint /contract to /contracts in tests

* fixed: typo for contracts function

* clean up and testing /properties

* fix: typo for subscription SID

* chore: minor changes to templates

* fix: update shared files

* refactor: Rebase templates with Python v2

* fail all jobs as soon as a stack fails

* fix: Equalise unicorn_web templates with other languages

* bug: unicorn_web requestApproval should only filter out properties in APPROVED state

* test: fixing EventBus name in PublicationEvaluationCompleted event payload of unicorn_web

* chore: minor changes to templates

* fix: update shared files

* refactor: Rebase templates with Python v2

* refactor: sequential deployments

* test: fail all jobs as soon as a stack fails

* fix: Equalise unicorn_web templates with other languages

* bug: unicorn_web requestApproval should only filter out properties in APPROVED state

* test: fixing EventBus name in PublicationEvaluationCompleted event payload of unicorn_web

* bug: changed date type to string

* docs: updated comments

* fix: merge conflicts

* test: temporarily disabling integration tests on GitHub Actions

---------

Co-authored-by: kechn <kechn@amazon.com>
Co-authored-by: Stephen Liedig <sliedig@amazon.com>
Co-authored-by: Kevin Chan <kevinwochan@gmail.com>
Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md)
- [Commits](npm/node-semver@v5.7.1...v5.7.2)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…rn_web/semver-5.7.2

chore(deps-dev): bump semver from 5.7.1 to 5.7.2 in /unicorn_web
Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.16 to 1.26.18.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@1.26.16...1.26.18)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.16 to 1.26.18.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@1.26.16...1.26.18)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.21.4 to 7.23.2.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.5 to 7.23.2.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…ties/urllib3-1.26.18

chore(deps): bump urllib3 from 1.26.16 to 1.26.18 in /unicorn_properties
…rn_contracts/babel/traverse-7.23.2

chore(deps-dev): bump @babel/traverse from 7.22.5 to 7.23.2 in /unicorn_contracts
…rn_web/babel/traverse-7.23.2

chore(deps-dev): bump @babel/traverse from 7.21.4 to 7.23.2 in /unicorn_web
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.21.4 to 7.23.2.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…rn_properties/babel/traverse-7.23.2

chore(deps-dev): bump @babel/traverse from 7.21.4 to 7.23.2 in /unicorn_properties
…cts/urllib3-1.26.18

chore(deps): bump urllib3 from 1.26.16 to 1.26.18 in /unicorn_contracts
Bumps [werkzeug](https://github.com/pallets/werkzeug) from 2.3.7 to 3.0.1.
- [Release notes](https://github.com/pallets/werkzeug/releases)
- [Changelog](https://github.com/pallets/werkzeug/blob/main/CHANGES.rst)
- [Commits](pallets/werkzeug@2.3.7...3.0.1)

---
updated-dependencies:
- dependency-name: werkzeug
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [werkzeug](https://github.com/pallets/werkzeug) from 2.3.7 to 3.0.1.
- [Release notes](https://github.com/pallets/werkzeug/releases)
- [Changelog](https://github.com/pallets/werkzeug/blob/main/CHANGES.rst)
- [Commits](pallets/werkzeug@2.3.7...3.0.1)

---
updated-dependencies:
- dependency-name: werkzeug
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…ties/werkzeug-3.0.1

chore(deps-dev): bump werkzeug from 2.3.7 to 3.0.1 in /unicorn_properties
…cts/werkzeug-3.0.1

chore(deps-dev): bump werkzeug from 2.3.7 to 3.0.1 in /unicorn_contracts
Kevinwochan and others added 2 commits February 11, 2024 03:09
`save-state` and `set-output` commands used in GitHub Actions are deprecated and [GitHub recommends using environment files](https://github.blog/changelog/2023-07-24-github-actions-update-on-save-state-and-set-output-commands/).

This PR updates the usage of `::set-output` to `"$GITHUB_OUTPUT"`

Instructions for envvar usage from GitHub docs:

https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter
@sliedig sliedig merged commit 7318241 into main Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge PRs that are blocked for varying reasons need-issue PR is missing a related issue for tracking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants