[ユースケースビルダー] フォーム・オプションの定義に含まれる空白のチェックを追加 #960
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
エラーメッセージを i18n 対応 |
icoxfog417
force-pushed
the
feature/check_item_spaces
branch
from
d4e6641 to
4437262
Compare
Collaborator
再現確認プロンプトテンプレート側がプルダウンであっても、入力例がフリーフォーマットのため、一致させないことが出来てしまう 
|
Collaborator
|
メモ: |
Contributor
|
This PR is stale because it has been open for 30 days with no activity. |
Contributor
|
This PR was closed because it has been inactive for 14 days since being marked as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
変更内容の説明
ユースケースビルダーで入力項目を定義する際、ラベルやオプションに空白が含まれていた場合バリデーションエラーを出すように修正しました。
{{text: 入力}}という定義の場合、"入力"の前に空白があるためエラーが出力されます{{select:選択項目:1, 2, 3, 4}}という場合、オプションの各数字の前に空白があるためエラーが出力されます画面イメージ
背景
特にselectの入力例を設定する際、意図せず空白が含まれていると入力例と空白が含まれたoptionがマッチせず、値が設定されない事態が起こる (#958)。ユースケースの作成者からすると非常に気づきにくいので、ユースケースを定義する段階でバリデーションエラーを表示することで速やかに修正できるようにする
チェック項目
npm run lintを実行したnpm run cdk:testを実行しスナップショット差分がある場合はnpm run cdk:test:update-snapshotを実行してスナップショットを更新した関連する Issue
#958