fix font family and change noto sans jp #985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wadabee
approved these changes
Apr 7, 2025
Contributor
wadabee
left a comment
wadabee
left a comment
There was a problem hiding this comment.
LGTM
Thank you for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
以下のキャプチャーの様にフォントの読み込みに失敗しているので、修正のプルリクエストです。
スペースを含むフォントの場合は、ダブルクオーテーションで囲う必要があるようです。
修正後以下の様にフォントが読み込まれています。
M PLUS Rounded 1c だと、以下のような形で、サイズによってはあまりきれいではないので、 Noto Sans JP に変えてプルリクエストさせていただいています。
M PLUS Rounded 1c
Noto Sans JP
フォント自体の変更を行うかどうかはご判断いただき、変えない方がいい場合は、 M PLUS Rounded 1c にダブルクオーテーションを付けた形でマージしていただければと思います。
Checklist
npm run lintnpm run cdk:testand if there are snapshot differences, executenpm run cdk:test:update-snapshotto update snapshotsRelated Issues
Please list related issues as much as possible.