Skip to content
This repository was archived by the owner on Mar 13, 2023. It is now read-only.

Conversation

@tmscarla
Copy link
Contributor

Description

Rewrite Cluster list page incorporating a list of best-practices enhancements.

Changes

  • Added i18n strings
  • Leveraged userQuery in ListClusters() function
  • Removed TS errors
  • Added unit tests for Clusters.tsx

How Has This Been Tested?

npm run dev opened and navigated in cluster list page

$ npm run test
Test Suites: 3 passed, 3 total
Tests:       18 passed, 18 total
Snapshots:   0 total

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@tmscarla tmscarla force-pushed the tmscarla/cluster-list-enhancements branch from 7b1357b to 2d22243 Compare July 27, 2022 09:27
@tmscarla tmscarla force-pushed the tmscarla/cluster-list-enhancements branch from 2d22243 to 7060fb8 Compare July 27, 2022 10:04
@tmscarla tmscarla requested a review from mtfranchetto July 27, 2022 10:06
@tmscarla tmscarla merged commit aa9475b into main Jul 27, 2022
@tmscarla tmscarla deleted the tmscarla/cluster-list-enhancements branch July 27, 2022 10:36
@mtfranchetto mtfranchetto mentioned this pull request Aug 4, 2022
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants