This repository was archived by the owner on Mar 13, 2023. It is now read-only.
Remove superfluous SNS topic from PCM Cfn template #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes the unused EcrImageBuilderSNSTopic from the PCM CloudFormation template. The topic was initially added to the PC API CloudFromation template in: - aws/aws-parallelcluster#3054 and was used when updating the Docker image to switch the image backing the PC API Lambda function. This SNS topic is not used in the PCM template and can therefore be removed.
mtfranchetto
approved these changes
Aug 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch removes the unused
EcrImageBuilderSNSTopicfrom the PCM CloudFormation template. The topic was initially added to the PC API CloudFromation template in #3054 and was used when updating the Docker image to switch the image, backing the PC API Lambda function. This SNS topic is not used in the PCM template and can therefore be removed.Tests
Deployed a new PCM Cfn stack and performed the relevant tests in the checklist below.
PR Quality Checkilst
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.