Skip to content
This repository was archived by the owner on Mar 13, 2023. It is now read-only.

Conversation

@mtfranchetto
Copy link
Contributor

Description

Introducing the support of ParallelCluster Flexible Instance Types.
Single instance types are still supported if PC 3.2.0 is installed through PCM.

To ensure backwards compatibility, I have extracted all instance types checks into separate files, and switch between the two versions based on a feature flag.
The single instance type code won't be touched or tested as it's going to be deprecated, and then removed, in future releases.

Moreover:

  • removed the GDR check, optional since PC 3.0.1
  • removed checks for Multithreading support as they weren't needed
  • fixed the default instance type for compute resource, defaulted to c5n.large

N.B. the dry run will fail because in PC 3.3.0b1 (the latest version available at the moment) the Instances field is named InstanceTypeList. In PC 3.3.0 it will be named properly, but if you need to create some clusters in the meantime, just rename the field manually before creating a cluster.

For tech debt: since this PR is already complex I did not fix hardcoded labels or TS warnings. This will be done in a subsequent PR.

How Has This Been Tested?

  • dry run with PC 3.3.0b1 and created queues and compute resources with multiple instance types (see video)
  • tested the old flow with PC 3.2.0

Feature recording

Screen.Recording.2022-10-21.at.10.48.37.mov

References

PR Quality Checklist

  • I added tests to new or existing code
  • I removed hardcoded strings and used our i18n solution instead (see here)
  • I checked that infrastructure/update_infrastructure.sh runs without any error
  • I checked that npm run build builds without any error
  • I checked that clusters are listed correctly
  • I checked that a new cluster can be created (config is produced and dry run passes)
  • I checked that login and logout work as expected

In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mtfranchetto mtfranchetto force-pushed the feature/instancetypes branch from 7288b00 to 46ac77f Compare October 21, 2022 13:41
@mtfranchetto mtfranchetto merged commit dbd40c1 into main Oct 24, 2022
@mtfranchetto mtfranchetto deleted the feature/instancetypes branch October 24, 2022 07:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants