This repository was archived by the owner on Mar 13, 2023. It is now read-only.
Flexible Instance Types #329
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introducing the support of ParallelCluster Flexible Instance Types.
Single instance types are still supported if PC 3.2.0 is installed through PCM.
To ensure backwards compatibility, I have extracted all instance types checks into separate files, and switch between the two versions based on a feature flag.
The single instance type code won't be touched or tested as it's going to be deprecated, and then removed, in future releases.
Moreover:
c5n.largeN.B. the dry run will fail because in PC 3.3.0b1 (the latest version available at the moment) the
Instancesfield is namedInstanceTypeList. In PC 3.3.0 it will be named properly, but if you need to create some clusters in the meantime, just rename the field manually before creating a cluster.For tech debt: since this PR is already complex I did not fix hardcoded labels or TS warnings. This will be done in a subsequent PR.
How Has This Been Tested?
Feature recording
Screen.Recording.2022-10-21.at.10.48.37.mov
References
PR Quality Checklist
i18nsolution instead (see here)npm run buildbuilds without any errorIn order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.