Skip to content
This repository was archived by the owner on Mar 13, 2023. It is now read-only.

Conversation

@mendaomn
Copy link
Contributor

@mendaomn mendaomn commented Oct 24, 2022

Description

This PR adds the attribution files to the project. In addition, these files are being added to the distributed product at build time

PLEASE NOTE: As it's been implemented, hosting the attribution doc while developing locally would require running the npm run copy-attributions script.

Changes

  • add attribution files to the resources/attributions folder
  • add prebuild script to make sure the application's attribution file is publicly hosted
  • add container's attributions file to the Docker image

Changelog entry

  • Add attribution files to the project

How Has This Been Tested?

  • manually by building the Dockerfile.awslambda and checking inside the container via command line that both files are present and catable

PR Quality Checklist

  • I added tests to new or existing code
  • I removed hardcoded strings and used our i18n solution instead (see here)
  • I checked that infrastructure/update_infrastructure.sh runs without any error
  • I checked that npm run build builds without any error
  • I checked that clusters are listed correctly
  • I checked that a new cluster can be created (config is produced and dry run passes)
  • I checked that login and logout work as expected

In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mendaomn mendaomn requested a review from mtfranchetto October 24, 2022 09:20
mtfranchetto
mtfranchetto previously approved these changes Oct 24, 2022
@mtfranchetto
Copy link
Contributor

Approved with a minor suggestion

@mendaomn mendaomn force-pushed the attribution-doc-split branch from 5366313 to 055dc61 Compare October 24, 2022 14:03
@mendaomn mendaomn merged commit ec8725a into main Oct 24, 2022
@mendaomn mendaomn deleted the attribution-doc-split branch October 24, 2022 14:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants