Skip to content
This repository was archived by the owner on Mar 13, 2023. It is now read-only.

Conversation

@mendaomn
Copy link
Contributor

Description

This PR fixes the following scenario:

  • full page reload of the / page
  • sidebar active item not being highlighted

Changes

  • derive activeHref from the pathname at every location change

How Has This Been Tested?

  • full page reload
  • navigation through all sections
  • full page reload of deep nested path (/clusters/{clustername})

PR Quality Checklist

  • I added tests to new or existing code
  • I removed hardcoded strings and used our i18n solution instead (see here)
  • I checked that infrastructure/update_infrastructure.sh runs without any error
  • I checked that npm run build builds without any error
  • I checked that clusters are listed correctly
  • I checked that a new cluster can be created (config is produced and dry run passes)
  • I checked that login and logout work as expected

In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mendaomn mendaomn merged commit 34abf50 into main Oct 26, 2022
@mendaomn mendaomn deleted the fix-sidebar-active-item branch October 26, 2022 14:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants